Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35282 )
Change subject: superio/smsc/lpc47b397: fix regression in ops override ......................................................................
superio/smsc/lpc47b397: fix regression in ops override
b0d868e8fe3f9a13f9be109fc3b73dfa949bec15 introduced a regression
Change-Id: I231888f2702027a80f25eb418c4e4703e55db920 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/smsc/lpc47b397/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/35282/1
diff --git a/src/superio/smsc/lpc47b397/superio.c b/src/superio/smsc/lpc47b397/superio.c index ad8153f..4b9e345 100644 --- a/src/superio/smsc/lpc47b397/superio.c +++ b/src/superio/smsc/lpc47b397/superio.c @@ -139,7 +139,7 @@ { NULL, LPC47B397_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, LPC47B397_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, 0x07ff, 0x07ff, }, - { NULL_hwm, LPC47B397_HWM, PNP_IO0, 0x07f0, }, + { &ops_hwm, LPC47B397_HWM, PNP_IO0, 0x07f0, }, { NULL, LPC47B397_RT, PNP_IO0, 0x0780, }, };
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35282 )
Change subject: superio/smsc/lpc47b397: fix regression in ops override ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35282 )
Change subject: superio/smsc/lpc47b397: fix regression in ops override ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35282 )
Change subject: superio/smsc/lpc47b397: fix regression in ops override ......................................................................
superio/smsc/lpc47b397: fix regression in ops override
b0d868e8fe3f9a13f9be109fc3b73dfa949bec15 introduced a regression
Change-Id: I231888f2702027a80f25eb418c4e4703e55db920 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35282 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marcello Sylvester Bauer sylvblck@sylv.io Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/superio/smsc/lpc47b397/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Marcello Sylvester Bauer: Looks good to me, but someone else must approve
diff --git a/src/superio/smsc/lpc47b397/superio.c b/src/superio/smsc/lpc47b397/superio.c index ad8153f..4b9e345 100644 --- a/src/superio/smsc/lpc47b397/superio.c +++ b/src/superio/smsc/lpc47b397/superio.c @@ -139,7 +139,7 @@ { NULL, LPC47B397_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, LPC47B397_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, 0x07ff, 0x07ff, }, - { NULL_hwm, LPC47B397_HWM, PNP_IO0, 0x07f0, }, + { &ops_hwm, LPC47B397_HWM, PNP_IO0, 0x07f0, }, { NULL, LPC47B397_RT, PNP_IO0, 0x0780, }, };
-
Arthur Heymans (Code Review) -
Felix Held (Code Review)
-
Marcello Sylvester Bauer (Code Review)