Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
......................................................................
Patch Set 12: Code-Review+2
(2 comments)
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/58798/comment/2304c224_6c84b3c6
PS10, Line 156: Return (Arg3)
or even building on the below, would it also be correct to do something like […]
decided to leave this as-is for now, will dig into a better solution later
https://review.coreboot.org/c/coreboot/+/58798/comment/dda9b228_7233f160
PS10, Line 190: Local0 |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING |
: INTER_DOMAIN_USB4_INTERNET_PROTOCOL
Up to you, Google has more TGL boards than us and System76 combined but... […]
decided to leave this as-is for now, will dig into a better solution later
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Gerrit-Change-Number: 58798
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 10 Nov 2021 22:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment