Attention is currently required from: Tarun Tuli, Kapil Porwal, Lean Sheng Tan, Elyes Haouas.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69032 )
Change subject: soc/intel: Include <cpu/cpu.h> instead of <arch/cpu.h> ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/69032/comment/1025f2e0_2e9393a6 PS1, Line 11: #include <intelblocks/cse_layout.h> : #include <intelblocks/cse.h> nit: I would leave this two ion their original order, looks somehow weird this way...But up to you.
File src/soc/intel/elkhartlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/69032/comment/27d92ac4_5aefb5fd PS1, Line 11: #include <device/pci.h> Same order comment applies here.
File src/soc/intel/icelake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/69032/comment/b6ff2f94_e58087d0 PS1, Line 10: #include <device/pci.h> And here as well as in other files re-ordering PCI includes.