HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46175 )
Change subject: mb/google/kahlee: Convert to ASL 2.0 syntax ......................................................................
mb/google/kahlee: Convert to ASL 2.0 syntax
Change-Id: Ieba23eb41c48e03b54ec90e86acace03f696fbe3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl 2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46175/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl index d151e1d..ced2e2d 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl @@ -29,10 +29,10 @@ _SB.PCI0.FPTS ()
/* Clear wake status structure. */ - Store (0, PEWD) - Store (0, Index(WKST,0)) - Store (0, Index(WKST,1)) - Store (7, UPWS) + PEWD = 0 + WKST [0] = 0 + WKST [1] = 0 + UPWS = 7 }
/* diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl index 32a6549..73499b0 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -21,10 +21,10 @@ /* Convert from Degrees C to 1/10 Kelvin for ACPI */ Method (CTOK, 1) { /* 10th of Degrees C */ - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
/* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) } @@ -50,23 +50,23 @@ Method (_TMP, 0, Serialized) { /* Get temperature from EC in deci-kelvin */ - Store (_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 =_SB.PCI0.LPCB.EC0.TSRD (TMPS)
/* Critical temperature in deci-kelvin */ - Store (CTOK (\TCRT), Local1) + Local1 = CTOK (\TCRT)
- If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + If (Local0 >= Local1) { + Debug = "CRITICAL TEMPERATURE" + Debug = Local0
/* Wait 1 second for EC to re-poll */ Sleep (1000)
/* Re-read temperature from EC */ - Store (_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 =_SB.PCI0.LPCB.EC0.TSRD (TMPS)
- Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Debug = "RE-READ TEMPERATURE" + Debug = Local0 }
Return (Local0)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46175
to look at the new patch set (#2).
Change subject: mb/google/kahlee: Convert to ASL 2.0 syntax ......................................................................
mb/google/kahlee: Convert to ASL 2.0 syntax
Change-Id: Ieba23eb41c48e03b54ec90e86acace03f696fbe3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl 2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46175/2