Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52734 )
Change subject: acpi: add Generic Initiator Affinity structure for SRAT ......................................................................
Patch Set 1:
(6 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/52734/comment/627dcfad_2683c257 PS1, Line 512: ;
remove this
Ack
https://review.coreboot.org/c/coreboot/+/52734/comment/8b9aa105_643d0cab PS1, Line 512: u16 seg, u8 bus, u8 dev, u8 func, u32 flags);
align this with the previous line
Ack
https://review.coreboot.org/c/coreboot/+/52734/comment/58955361_26aaa973 PS1, Line 514: 5; /* Generic Initiator Affinity structure */ : gia->length = sizeof(acpi_srat_gia_t);
enums or #defines would be nice here instead of magic numbers
Ack
https://review.coreboot.org/c/coreboot/+/52734/comment/bc93419f_1bffaa12 PS1, Line 517: 1; /* PCIe device handle */
enums or #defines would be nice here instead of magic numbers
Ack
https://review.coreboot.org/c/coreboot/+/52734/comment/c1fa803d_50f9a381 PS1, Line 521: (((dev) & 0x1F) << 3)
`PCI_SLOT(dev)`
Ack
https://review.coreboot.org/c/coreboot/+/52734/comment/71731026_b2237a44 PS1, Line 521: ((func) & 0x07)
`PCI_FUNC(func)`
Ack
-
Jonathan Zhang (Code Review)