Change in ...coreboot[master]: ec/lenovo/h8: Implement ACPI methods to set battery thresholds - coreboot-gerrit

2 Mar 2019


      Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23178 )
Change subject: ec/lenovo/h8: Implement ACPI methods to set battery thresholds
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/#/c/23178/24//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/#/c/23178/24//COMMIT_MSG@9 
PS24, Line 9: There are two known (yet) different ways to manage battery thresholds.
            : This patch implements them and adds a way to enable them for
            : different mainboards.
...
Could you please mention that in the commit message?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/23178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a90f9e9b32462b8a5e9bc8d3087ae0fea563ea5
Gerrit-Change-Number: 23178
Gerrit-PatchSet: 27
Gerrit-Owner: Alexey Derlaft derlafff@ya.ru
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Alexey Derlaft derlafff@ya.ru
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.com
Gerrit-Reviewer: Marcello Sylvester Bauer sylvblck@sylv.io
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sat, 02 Mar 2019 13:44:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev me@ch1p.com
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment