Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60120 )
Change subject: soc/amd/common/block/spi/fch_spi_ctrl: improve printk messages ......................................................................
soc/amd/common/block/spi/fch_spi_ctrl: improve printk messages
Replace FCH_SC with FCH SPI in the printk messages to make those a bit clearer and also remove an unneeded line break in another printk call.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I6ff02163e6a48a2cc8b7fe89b15826e154715d29 --- M src/soc/amd/common/block/spi/fch_spi_ctrl.c 1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60120/1
diff --git a/src/soc/amd/common/block/spi/fch_spi_ctrl.c b/src/soc/amd/common/block/spi/fch_spi_ctrl.c index 33e1139..f790247 100644 --- a/src/soc/amd/common/block/spi/fch_spi_ctrl.c +++ b/src/soc/amd/common/block/spi/fch_spi_ctrl.c @@ -98,7 +98,7 @@ spi_write8(SPI_CMD_TRIGGER, SPI_CMD_TRIGGER_EXECUTE);
if (wait_for_ready()) { - printk(BIOS_ERR, "FCH_SC Error: Timeout executing command\n"); + printk(BIOS_ERR, "FCH SPI Error: Timeout executing command\n"); return -1; }
@@ -121,8 +121,7 @@ const uint8_t *bufout = dout;
if (CONFIG(SOC_AMD_COMMON_BLOCK_SPI_DEBUG)) - printk(BIOS_DEBUG, "%s(%zx, %zx)\n", __func__, bytesout, - bytesin); + printk(BIOS_DEBUG, "%s(%zx, %zx)\n", __func__, bytesout, bytesin);
/* First byte is cmd which cannot be sent through FIFO */ cmd = bufout[0]; @@ -136,7 +135,7 @@ * and followed by other SPI commands. */ if (bytesout + bytesin > SPI_FIFO_DEPTH) { - printk(BIOS_WARNING, "FCH_SC: Too much to transfer, code error!\n"); + printk(BIOS_WARNING, "FCH SPI: Too much to transfer, code error!\n"); return -1; }