[M] Change in coreboot[master]: util/cbfstool: Add a new mechanism to provide a memory mapped
Attention is currently required from: Nico Huber, Maximilian Brune, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped ......................................................................
Patch Set 6:
(5 comments)
File util/cbfstool/cbfstool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163294): https://review.coreboot.org/c/coreboot/+/68160/comment/dd3a56d4_45d5bd82 PS6, Line 395: * Default decode window lives just below 4G boundary in host space and maps up to a line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163294): https://review.coreboot.org/c/coreboot/+/68160/comment/386faebd_f9d19b5e PS6, Line 396: * maximum of 16MiB. If the window is smaller than 16MiB, the SPI flash window is mapped line length of 104 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163294): https://review.coreboot.org/c/coreboot/+/68160/comment/13bfe989_8a345e95 PS6, Line 399: add_mmap_window(std_window_flash_offset, DEFAULT_DECODE_WINDOW_TOP - std_window_size, std_window_size); line length of 119 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163294): https://review.coreboot.org/c/coreboot/+/68160/comment/a6e8a778_5b75110c PS6, Line 408: ERROR("Flash space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163294): https://review.coreboot.org/c/coreboot/+/68160/comment/43f36d16_41b563c9 PS6, Line 418: ERROR("Host space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 134 exceeds 96 columns
-
build bot (Jenkins) (Code Review)