Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48782 )
Change subject: vc/google/chromeos: Move chromeos_set_me_hash() prototype ......................................................................
vc/google/chromeos: Move chromeos_set_me_hash() prototype
Change allows to remove some <chromeos/gnvs.h> exposure from coreboot proper.
Change-Id: I7817914cc7b248331bb8fa79baa642ed548bbc11 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/gnvs.h 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/48782/1
diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h index 233eb42..315d693 100644 --- a/src/vendorcode/google/chromeos/chromeos.h +++ b/src/vendorcode/google/chromeos/chromeos.h @@ -45,6 +45,7 @@ #endif /* CONFIG_CHROMEOS_RAMOOPS */
void cbmem_add_vpd_calibration_data(void); +void chromeos_set_me_hash(u32*, int);
/** * get_dsm_calibration_from_key - Gets value related to DSM calibration from VPD diff --git a/src/vendorcode/google/chromeos/gnvs.h b/src/vendorcode/google/chromeos/gnvs.h index 74324a0..e44e292 100644 --- a/src/vendorcode/google/chromeos/gnvs.h +++ b/src/vendorcode/google/chromeos/gnvs.h @@ -45,7 +45,6 @@ } __packed chromeos_acpi_t;
void chromeos_init_chromeos_acpi(chromeos_acpi_t *init); -void chromeos_set_me_hash(u32*, int); chromeos_acpi_t *chromeos_get_chromeos_acpi(void);
#endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48782 )
Change subject: vc/google/chromeos: Move chromeos_set_me_hash() prototype ......................................................................
Patch Set 3: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48782 )
Change subject: vc/google/chromeos: Move chromeos_set_me_hash() prototype ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48782 )
Change subject: vc/google/chromeos: Move chromeos_set_me_hash() prototype ......................................................................
vc/google/chromeos: Move chromeos_set_me_hash() prototype
Change allows to remove some <chromeos/gnvs.h> exposure from coreboot proper.
Change-Id: I7817914cc7b248331bb8fa79baa642ed548bbc11 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48782 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/gnvs.h 2 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h index 233eb42..315d693 100644 --- a/src/vendorcode/google/chromeos/chromeos.h +++ b/src/vendorcode/google/chromeos/chromeos.h @@ -45,6 +45,7 @@ #endif /* CONFIG_CHROMEOS_RAMOOPS */
void cbmem_add_vpd_calibration_data(void); +void chromeos_set_me_hash(u32*, int);
/** * get_dsm_calibration_from_key - Gets value related to DSM calibration from VPD diff --git a/src/vendorcode/google/chromeos/gnvs.h b/src/vendorcode/google/chromeos/gnvs.h index 74324a0..e44e292 100644 --- a/src/vendorcode/google/chromeos/gnvs.h +++ b/src/vendorcode/google/chromeos/gnvs.h @@ -45,7 +45,6 @@ } __packed chromeos_acpi_t;
void chromeos_init_chromeos_acpi(chromeos_acpi_t *init); -void chromeos_set_me_hash(u32*, int); chromeos_acpi_t *chromeos_get_chromeos_acpi(void);
#endif
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)