[S] Change in coreboot[main]: soc/intel/pantherlake: Display Sign-of-Life during memory training

[Jérémy Compostella (Code Review)]

Attention is currently required from: Alok Agarwal, Anil Kumar K, Intel coreboot Reviewers, Jayvik Desai, Jeremy Compostella, Julius Werner, Karthik Ramasubramanian, Paul Menzel, Pranava Y N, Subrata Banik, Vikrant L Jadeja.

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email )

Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training
......................................................................

Patch Set 23:

(1 comment)

File src/soc/intel/pantherlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/85454/comment/39342e54_4252f9e2?usp... :
PS21, Line 387: 	m_cfg->VgaMessage = (efi_uintn_t)ux_locales_get_text(UX_LOCALE_MSG_MEMORY_TRAINING);
> Even if we decide to take no action, we can update the TODO with the reason for code duplication. […]

There is no good reason for a "TO-DO" in the code because the code is complete, and the refactoring we are considering is beyond the scope of this particular early Sign-of-Life Change List (CL). In addition, the code duplication approach is not new; it has been ongoing for a few generations already, and there are some good reasons behind it.

I understand that we want to challenge the status quo, and I am the first in line to push for changes in that area, as code duplication creates more maintenance work and prevents improvements from cascading to all generations. Our only goal should be to ensure that we track this activity. An extra TO-DO is superfluous and looks like code pollution to me in this particular case.

We have a bug tracker opened (b/398872610), and we can move the discussion to another Change List (CL) available at https://review.coreboot.org/c/coreboot/+/86532.

Let's close this discussion since this CL needs to land, and holding it back is not justified.