Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45105 )
Change subject: mb/system76/lemp9: Don't configure unused USB3 port ......................................................................
mb/system76/lemp9: Don't configure unused USB3 port
Don't configure USB3 port 4 since it's not used.
Change-Id: I6919f5ec3a5be53373f2ab75063764287b53baf5 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45105/1
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index c07b687..11232570 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -95,7 +95,7 @@ register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 1 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C port 2 register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 3 - register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # NC + register "usb3_ports[3]" = "USB3_PORT_EMPTY" # NC register "usb3_ports[4]" = "USB3_PORT_EMPTY" # NC register "usb3_ports[5]" = "USB3_PORT_EMPTY" # HSIO used by PCIe root port #6 register "usb3_ports[6]" = "USB3_PORT_EMPTY" # NC
Hello Jeremy Soller, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45105
to look at the new patch set (#2).
Change subject: mb/system76/lemp9: Don't enable unused USB3 port ......................................................................
mb/system76/lemp9: Don't enable unused USB3 port
Don't configure USB3 port 4 since it's not used.
Change-Id: I6919f5ec3a5be53373f2ab75063764287b53baf5 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45105/2
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45105 )
Change subject: mb/system76/lemp9: Don't enable unused USB3 port ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45105 )
Change subject: mb/system76/lemp9: Don't enable unused USB3 port ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45105 )
Change subject: mb/system76/lemp9: Don't enable unused USB3 port ......................................................................
mb/system76/lemp9: Don't enable unused USB3 port
Don't configure USB3 port 4 since it's not used.
Change-Id: I6919f5ec3a5be53373f2ab75063764287b53baf5 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/45105 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jeremy Soller jeremy@system76.com Reviewed-by: Michael Niewöhner --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Jeremy Soller: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index e9e3aa3..c0a2835 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -95,7 +95,7 @@ register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 1 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C port 2 register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 3 - register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # NC + register "usb3_ports[3]" = "USB3_PORT_EMPTY" # NC register "usb3_ports[4]" = "USB3_PORT_EMPTY" # NC register "usb3_ports[5]" = "USB3_PORT_EMPTY" # HSIO used by PCIe root port #6 register "usb3_ports[6]" = "USB3_PORT_EMPTY" # NC
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45105 )
Change subject: mb/system76/lemp9: Don't enable unused USB3 port ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17846 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17845 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17844 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17843 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17842 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/17849 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17848 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17847
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Singer (Code Review)
-
Jeremy Soller (Code Review)
-
Michael Niewöhner (Code Review)