Attention is currently required from: Rob Barnes, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58638 )
Change subject: mb/google/guybrush: Move GSC_SOC_INT_L from GPIO_3 to GPIO_85
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58638/comment/0886cff2_13c90588
PS1, Line 162: e
Do we need to specify the alias again?
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/58638/comment/2741c64e_2a2028a5
PS1, Line 40: BID == 1: GSC_SOC_INT_L, BID > 1: Unused
Should we have an early_bid1 table?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019f10f2f457ab81bcff77ce8ca609b2b40cb2ea
Gerrit-Change-Number: 58638
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 27 Oct 2021 15:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment