Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60126 )
Change subject: soc/intel/alderlake: remove SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60126/comment/ef24f9f9_14aaa570
PS2, Line 7: do not lock GPP_B16/ GPP_B17
Please remove the space after the slash (/).
Done
https://review.coreboot.org/c/coreboot/+/60126/comment/e3ad8b95_3b192ee0
PS2, Line 9: Do not lock GPP_B16/ GPP_B17 because we set it as NF2. This will let i2c device lost function after warm reboot.
Please wrap lines after 72 characters.
Done
https://review.coreboot.org/c/coreboot/+/60126/comment/5462a66a_f5741bdd
PS2, Line 9: This will let i2c device lost function after warm reboot.
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/60126/comment/85b1b449_5b4583d2
PS2, Line 13: work
works
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I106ddc96c3185656d3f1fbcd45f198d2d46f3f4d
Gerrit-Change-Number: 60126
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 17 Dec 2021 00:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment