Attention is currently required from: Jakub Czapiga, Michał Żygowski, Subrata Banik.
Marek Maślanka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/smbus/tco.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/dc04cb42_33128d61 :
PS10, Line 148: u32 tco_get_timer_period(void)
Please mark these functions with `__attribute__((weak))` so boards can overload them if needed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf7971f8407920a553fd91d2ed04193c882e08f1
Gerrit-Change-Number: 79909
Gerrit-PatchSet: 12
Gerrit-Owner: Marek Maślanka
mmaslanka@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 29 Jan 2024 09:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Gerrit-MessageType: comment