Attention is currently required from: Justin Frodsham, Raul Rangel, Marshall Dawson, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h
......................................................................
Patch Set 11:
(3 comments)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/254d6f6b_ee77cab5
PS10, Line 196: Currently unused by FSP
Based on Matt's comment, I infer this should change too.
this is mostly a copy of PlatformHooksPeim.h. that struct field gets copied into some other data structure, but haven't further traced that data flow
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/aa808259_456f3019
PS7, Line 179: port_params
in short token and value pairs. […]
added a comment
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/5770845d_ed6f70c0
PS4, Line 57: CLK_GPP_REQ0 = 0x09,
added a TODO
the uefi reference implementation doesn't have those, so i remove them
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 21:46:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Matt Papageorge
matthewpapa07@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment