Attention is currently required from: Frank Wu, Furquan Shaikh, Martin Roth, Alan Lee, Angel Pons, Ivy Jian, EricR Lai. John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49783 )
Change subject: drivers/generic/bayhub_lv2: Add driver for BayHub lv2 ......................................................................
Patch Set 8:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49783/comment/4290442f_ce9d90a3 PS7, Line 13:
We lost the TEST= message in patch set 3. […]
Done
File src/drivers/generic/bayhub_lv2/lv2.c:
https://review.coreboot.org/c/coreboot/+/49783/comment/97b0f512_9bace3a5 PS7, Line 19: if (config && config->power_saving) {
I assume this may need other settings like bayhub EMMC bridge. But can change later if need.
Done
https://review.coreboot.org/c/coreboot/+/49783/comment/828b01b0_07375916 PS7, Line 19: if (config && config->power_saving) {
I assume this may need other settings like bayhub EMMC bridge. But can change later if need.
Ack
https://review.coreboot.org/c/coreboot/+/49783/comment/5084b374_380a6c5e PS7, Line 19: if (config && config->power_saving) {
I assume this may need other settings like bayhub EMMC bridge. But can change later if need.
Done
https://review.coreboot.org/c/coreboot/+/49783/comment/c010c7b9_43cdbf0c PS7, Line 26: 0x0FFFFFFF
We are expecting vendor to register coreboot account and do the change :p
Ack
https://review.coreboot.org/c/coreboot/+/49783/comment/be2a65c2_88fbe04b PS7, Line 26: 0x0FFFFFFF
We are expecting vendor to register coreboot account and do the change :p
Done
https://review.coreboot.org/c/coreboot/+/49783/comment/7671bfc9_18472c42 PS7, Line 26: 0x0FFFFFFF
We are expecting vendor to register coreboot account and do the change :p
Done
-
John Su (Code Review)