Change in ...coreboot[master]: hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT

[Kane Chen (Code Review)]

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32338

Change subject: hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT
......................................................................

hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT

This change is to enable DEBUG_CONSENT_CANNONLAKE if
CHROMEOS_SOC_DEBUG_CONSENT=y on hatch.

Change-Id: Ibf2431d7be9722f7bbb2c3fdff9d5143de1b0642
Signed-off-by: Kane Chen 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/32338/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 041ac2d..a14f8d3 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -103,3 +103,11 @@
    select VBOOT_LID_SWITCH

endif # BOARD_GOOGLE_BASEBOARD_HATCH
+
+if CHROMEOS_SOC_DEBUG_CONSENT
+
+config DEBUG_CONSENT_CANNONLAKE
+	int
+	default 3
+
+endif # CHROMEOS_SOC_DEBUG_CONSENT

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32338 )

Change subject: hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32338/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32338/1//COMMIT_MSG@10 
PS1, Line 10: CHROMEOS_SOC_DEBUG_CONSENT=y on hatch.
Please add the motivation/reasoning.

[Kane Chen (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32338

to look at the new patch set (#2).

Change subject: hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT
......................................................................

hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT

This change is to enable DEBUG_CONSENT_CANNONLAKE if
CHROMEOS_SOC_DEBUG_CONSENT=y on hatch.

Chrome OS developers can set a flag to enable SOC debug capability
easily while building coreboot for Chrome OS.

Change-Id: Ibf2431d7be9722f7bbb2c3fdff9d5143de1b0642
Signed-off-by: Kane Chen 
---
M src/mainboard/google/hatch/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/32338/2

[Kane Chen (Code Review)]

Kane Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32338 )

Change subject: hatch: Enable DEBUG_CONSENT_CANNONLAKE by CHROMEOS_SOC_DEBUG_CONSENT
......................................................................

Abandoned