Attention is currently required from: Furquan Shaikh, Martin Roth, Henry Sun, Evan Green, Justin TerAvest. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49469 )
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection ......................................................................
Patch Set 12:
(5 comments)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/49469/comment/987f9908_a031617d PS12, Line 19: /* C12 : AP_PEN_DET_ODL */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49469/comment/411ac7dd_3c30dceb PS12, Line 20: PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49469/comment/2750411f_0f19911f PS12, Line 20: PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49469/comment/bb73fbba_220ffd1f PS12, Line 29: if (board_version >= 6 ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/49469/comment/85013b77_d6318d12 PS12, Line 32: } else { else is not generally useful after a break or return