Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. Sandeep Maheswaram has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56091 )
Change subject: soc/qualcomm/common/usb: Add support for common USB driver ......................................................................
Patch Set 41:
(4 comments)
File src/soc/qualcomm/common/include/soc/usb/qusb_phy.h:
https://review.coreboot.org/c/coreboot/+/56091/comment/71b015c4_9a8b5ac2 PS38, Line 95:
same here
Done
File src/soc/qualcomm/common/usb/snps_usb_phy.c:
https://review.coreboot.org/c/coreboot/+/56091/comment/e3d75051_081cd510 PS38, Line 44: UTMI_PHY_CMN_CTRL_OVERRIDE_EN,
This can still fit on the previous line
Done
https://review.coreboot.org/c/coreboot/+/56091/comment/e7928fd5_d9892ab6 PS38, Line 48: POR, POR);
This too (and many more times below).
Done
https://review.coreboot.org/c/coreboot/+/56091/comment/690b0e70_93be0424 PS38, Line 73: PARAM_OVRD_MASK, override_data->parameter_override_x2);
What about parameter_override_x3?
Done
-
Sandeep Maheswaram (Code Review)