Attention is currently required from: Felix Singer, Martin L Roth, Matt DeVillier, Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67119 )
Change subject: /: Update and rewrite README.md
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File README.md:
https://review.coreboot.org/c/coreboot/+/67119/comment/efe31de3_c8306513
PS4, Line 27: `git clone https://review.coreboot.org/coreboot.git%60.
Maybe point to `https://review.coreboot.org/admin/repos/coreboot,general%60 as it includes the command? In case something changes in Gerrit
https://review.coreboot.org/c/coreboot/+/67119/comment/fd5e0e1a_6cbbb3ea
PS4, Line 37: suggest
What does "suggest" mean here?
https://review.coreboot.org/c/coreboot/+/67119/comment/5f43c415_623b5f12
PS4, Line 179:
There's also commonlib/bsd, should it be mentioned?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cd59d75da47b287029a9fc5eeddefaf99198965
Gerrit-Change-Number: 67119
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 13:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment