Attention is currently required from: Felix Singer, Martin L Roth, Matt DeVillier, Martin Roth.
Patch set 4:Code-Review +1
View Change
3 comments:
File README.md:
Patch Set #4, Line 27: `git clone https://review.coreboot.org/coreboot.git`.
Maybe point to `https://review.coreboot.org/admin/repos/coreboot,general` as it includes the command? In case something changes in Gerrit
Patch Set #4, Line 37: suggest
What does "suggest" mean here?
Patch Set #4, Line 179:
There's also commonlib/bsd, should it be mentioned?
To view, visit change 67119. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cd59d75da47b287029a9fc5eeddefaf99198965
Gerrit-Change-Number: 67119
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 01 Nov 2022 13:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment