Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56093 )
Change subject: mb/google/herobrine: Initialize USB by calling SOC method ......................................................................
Patch Set 39:
(3 comments)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134047): https://review.coreboot.org/c/coreboot/+/56093/comment/1b8394de_c9da761c PS39, Line 19: .parameter_override_x0 = 0xe6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134047): https://review.coreboot.org/c/coreboot/+/56093/comment/3aa86013_51f4199a PS39, Line 20: .parameter_override_x1 = 0x8b, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134047): https://review.coreboot.org/c/coreboot/+/56093/comment/eee8933d_842edeee PS39, Line 21: .parameter_override_x2 = 0x16, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)