Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73320 )
Change subject: soc/amd/stoneyridge/acpi: introduce and use ACPI_SCI_IRQ definition ......................................................................
soc/amd/stoneyridge/acpi: introduce and use ACPI_SCI_IRQ definition
IRQ9 is used as ACPI SCI IRQ, so add a define for that and use it in the code like it is also done in the other SoCs in soc/amd.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iddb51d70c15ab1d7088f62b61e22510bd1b30b1e --- M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/include/soc/acpi.h 2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/73320/1
diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index bc3e73a..6faf3b3 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -39,7 +39,7 @@ MP_IRQ_TRIGGER_DEFAULT | MP_IRQ_POLARITY_DEFAULT); /* SCI IRQ type override */ current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, - MP_BUS_ISA, 9, 9, + MP_BUS_ISA, ACPI_SCI_IRQ, ACPI_SCI_IRQ, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW);
return current; @@ -53,7 +53,7 @@ { printk(BIOS_DEBUG, "pm_base: 0x%04x\n", ACPI_IO_BASE);
- fadt->sci_int = 9; /* IRQ 09 - ACPI SCI */ + fadt->sci_int = ACPI_SCI_IRQ;
if (permanent_smi_handler()) { fadt->smi_cmd = APM_CNT; diff --git a/src/soc/amd/stoneyridge/include/soc/acpi.h b/src/soc/amd/stoneyridge/include/soc/acpi.h index 21ffd5f..302416e 100644 --- a/src/soc/amd/stoneyridge/include/soc/acpi.h +++ b/src/soc/amd/stoneyridge/include/soc/acpi.h @@ -6,6 +6,8 @@ #include <acpi/acpi.h> #include <amdblocks/acpi.h>
+#define ACPI_SCI_IRQ 9 + #if CONFIG(STONEYRIDGE_LEGACY_FREE) #define FADT_BOOT_ARCH ACPI_FADT_LEGACY_FREE #else