Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32750
Change subject: libpayload/drivers/i8042: Add fallthrough comment ......................................................................
libpayload/drivers/i8042: Add fallthrough comment
Ctrl-delete does nothing, so it falls through to the default case. Add a comment to make this explicit.
Found-by: Coverity Scan #1260878 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I4a6f51cb04696b6ebcb554c5667a5bbea58622c1 --- M payloads/libpayload/drivers/i8042/keyboard.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32750/1
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index 1035bf2..87d8d29 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -258,6 +258,7 @@ /* vulcan nerve pinch */ if ((modifier & KB_MOD_ALT) && reset_handler) reset_handler(); + /* fallthrough */ default: ret = 0; }
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32750 )
Change subject: libpayload/drivers/i8042: Add fallthrough comment ......................................................................
Patch Set 1: Code-Review+2
Technically it will never reach the point as it reboots the PC, but ok.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32750 )
Change subject: libpayload/drivers/i8042: Add fallthrough comment ......................................................................
libpayload/drivers/i8042: Add fallthrough comment
Ctrl-delete does nothing, so it falls through to the default case. Add a comment to make this explicit.
Found-by: Coverity Scan #1260878 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I4a6f51cb04696b6ebcb554c5667a5bbea58622c1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32750 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M payloads/libpayload/drivers/i8042/keyboard.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index 42431c3..cded638 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -258,6 +258,7 @@ /* vulcan nerve pinch */ if ((modifier & KB_MOD_ALT) && reset_handler) reset_handler(); + /* fallthrough */ default: ret = 0; }
-
Jacob Garber (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)