Change in coreboot[master]: lib/cbfs: Enable cbfs_cache for x86 - coreboot-gerrit

21 Oct 2021


      Attention is currently required from: Raul Rangel, Furquan Shaikh, Julius Werner, Karthik Ramasubramanian.
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56577 )
Change subject: lib/cbfs: Enable cbfs_cache for x86
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS3:
...
Yes, recovery mode would be affected. […]
I'm not very familiar with x86, but it sounds bad? I assume cli is clear interrupts, but `lgdtl` is apparently "Load Global Descriptor Table" which seems important.
00e00000 <_program>:
  e00000:       fa                      cli    
  e00001:       2e 0f 01 15 66 00 e0    lgdtl  %cs:0xe00066
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56577
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74434ef9250ff059e7587147b1456aeabbee33aa
Gerrit-Change-Number: 56577
Gerrit-PatchSet: 5
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aseda Aboagye aaboagye@google.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 21 Oct 2021 22:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Aseda Aboagye aaboagye@google.com
Gerrit-MessageType: comment