Attention is currently required from: Arthur Heymans, Benjamin Doron, Patrick Georgi.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: smmstorev2: Load the communication buffer at SMM setup ......................................................................
Patch Set 6:
(3 comments)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/79738/comment/8b70dd42_f095ca15 : PS6, Line 11: include <smmstore.h> Alphabetical order ?
File src/drivers/smmstore/ramstage.c:
https://review.coreboot.org/c/coreboot/+/79738/comment/24db8789_ea7a7972 : PS6, Line 23: struct smmstore_params_info info; : smmstore_get_info(&info); : I am a bit confused, why is `smmstore_get_info()` called ?
File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/79738/comment/9a5b971e_bd629ee6 : PS6, Line 10: #include <cpu/x86/smm.h> Alphabetical order ?