Attention is currently required from: Arthur Heymans, Benjamin Doron, Patrick Georgi.

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

View Change

3 comments:

• File src/cpu/x86/smm/smm_module_loader.c:

  • Patch Set #6, Line 11: include <smmstore.h>

    Alphabetical order ?

• File src/drivers/smmstore/ramstage.c:

  • Patch Set #6, Line 23:

    struct smmstore_params_info info;
    	smmstore_get_info(&info);
    
    

    I am a bit confused, why is `smmstore_get_info()` called ?

• File src/drivers/smmstore/store.c:

  • Patch Set #6, Line 10: #include <cpu/x86/smm.h>

    Alphabetical order ?

To view, visit change 79738. To unsubscribe, or for help writing mail filters, visit settings.