Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74102 )
Change subject: mb/google/myst: Add FW_CONFIG
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/myst/variants/myst/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74102/comment/ac611a6d_56a858ba
PS4, Line 20:
Do we need EMMC and NVME too? Also SD card?
I don't believe so. We only add fields for things that we need to know at boot and/or aren't queryable.
For reference, look at Skyrim: https://docs.google.com/spreadsheets/d/12TKNyhDUwTOVnmIehWQxVb0J7tj_sLUY6oNd...
And Myst: https://docs.google.com/spreadsheets/d/1CtfZr42hX4nnlswomMDDZfvGEmZycQxFFr4U...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If74c3649d4e8d174d9fe00a4b896c2351ee3ab19
Gerrit-Change-Number: 74102
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment