Attention is currently required from: Derek Huang, Eric Lai, Martin L Roth, Nick Vaccaro, Reka Norman, Shawn Ku, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78167?usp=email )
Change subject: mb/google/nissa/var/quandiso: Fix touchscreen probed flag
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78167/comment/09466ab7_cb86fa0e :
PS1, Line 9: detect flag isn't ready in firmware-nissa-15217.B
Are you sure? Some nissa variants use detect flags in nissa firmware branch already.
chromium:4769662 do not cherry-pick to firmware branch yet.
I used the firmware branch build firmware on quandiso board and it did not work.
Patchset:
PS1:
If this is true, should we do for all nissa boards?
No, this CL is for quandiso detected flag change on firmware branch too early.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78167?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I674b636e1c5d8554ba91d380c61d381d7db95054
Gerrit-Change-Number: 78167
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Derek Huang
derekhuang@google.com
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shawn Ku
shawnku@chromium.org
Gerrit-Comment-Date: Thu, 05 Oct 2023 02:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Gerrit-MessageType: comment