Attention is currently required from: Maulik V Vaghela.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55996 )
Change subject: soc/intel/alderlake: Add support for I2C6 and I2C7
......................................................................
Patch Set 7:
(2 comments)
This change is ready for review.
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55996/comment/54ba8e93_abc28f3f
PS6, Line 89: .slot = PCH_DEV_SLOT_SIO0,
This is taken care in this patch: […]
Done
File src/soc/intel/alderlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/55996/comment/6467e48f_ff6be3cb
PS6, Line 86: #define PCH_DEV_I2C6 _PCH_DEV(SIO0, 0)
Please remove duplicate entries
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55996
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id918d55e48b91993af9de8381995917aef55edc9
Gerrit-Change-Number: 55996
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Wed, 14 Jul 2021 05:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment