Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86419?usp=email )
Change subject: soc/intel/common/reset: Add low battery indicator delay
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/reset.c:
https://review.coreboot.org/c/coreboot/+/86419/comment/8372c39d_3602f262?usp... :
PS1, Line 29: if (CONFIG(PLATFORM_HAS_LOW_BATTERY_INDICATOR)) {
I don't think this needs to be checked here? This function is only called by code belonging to that feature anyway.
This function can be called by others in future (in case) so just intended to avoid a case when `do_low_battery_poweroff` might end up logging elog event and add delay.
WDYT ?
I have suashed this CL with CB:86361
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86419?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56bff7af8c9ddd9b34d19d2c0b6a76172eff3f31
Gerrit-Change-Number: 86419
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 17:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org