Attention is currently required from: Matt DeVillier, Sean Rhodes.
Paul Menzel has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email )
Change subject: mb/starlabs/starbook: Add Alder Lake N (N200) variant
......................................................................
Patch Set 22: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85714/comment/8640e694_409432df?usp... :
PS22, Line 7: Alder Lake N
Thank you, but the hyphen/minus should stay though: Alder Lake-N.
https://review.coreboot.org/c/coreboot/+/85714/comment/1a0b548d_be409f27?usp... :
PS22, Line 10: `github.com/starlabsltd/edk2/tree/uefipayload_vs`:
Make it a URL by prepending https://?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85714?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Gerrit-Change-Number: 85714
Gerrit-PatchSet: 22
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:47:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes