Change in coreboot[master]: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46040 )

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi

CBFS SAR and SAR tables in ACPI are currently supported only by Intel
WiFi devices. This change adds a check in `emit_sar_acpi_structures()`
to ensure that the PCI vendor for the device is Intel before
generating the SAR tables.

BUG=b:169802515
BRANCH=zork

Change-Id: Ibff437893a61ac9557cff243a70230f101089834
Signed-off-by: Furquan Shaikh 
---
M src/drivers/wifi/generic/generic.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/46040/1

diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c
index 48201fc..c7a32bd 100644
--- a/src/drivers/wifi/generic/generic.c
+++ b/src/drivers/wifi/generic/generic.c
@@ -44,12 +44,16 @@
    return -1;
 }

-static void emit_sar_acpi_structures(void)
+static void emit_sar_acpi_structures(const struct device *dev)
 {
    int i, j, package_size;
    struct wifi_sar_limits sar_limits;
    struct wifi_sar_delta_table *wgds;

+	/* CBFS SAR and SAR ACPI tables are currently used only by Intel WiFi devices. */
+	if (dev->vendor != PCI_VENDOR_ID_INTEL)
+		return;
+
    /* Retrieve the sar limits data */
    if (get_wifi_sar_limits(&sar_limits) < 0) {
    	printk(BIOS_ERR, "Error: failed from getting SAR limits!\n");
@@ -217,7 +221,7 @@

/* Fill Wifi sar related ACPI structures */
    if (CONFIG(USE_SAR))
-		emit_sar_acpi_structures();
+		emit_sar_acpi_structures(dev);

acpigen_pop_len(); /* Device */
    acpigen_pop_len(); /* Scope */

[Rob Barnes (Code Review)]

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46040 )

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

Patch Set 1: Code-Review+1

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46040 )

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Duncan Laurie, Michael Niewöhner, Rob Barnes, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46040

to look at the new patch set (#3).

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi

CBFS SAR and SAR tables in ACPI are currently supported only by Intel
WiFi devices. This change adds a check in `emit_sar_acpi_structures()`
to ensure that the PCI vendor for the device is Intel before
generating the SAR tables.

BUG=b:169802515
BRANCH=zork

Change-Id: Ibff437893a61ac9557cff243a70230f101089834
Signed-off-by: Furquan Shaikh 
---
M src/drivers/wifi/generic/generic.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/46040/3

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46040 )

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

Patch Set 6: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46040 )

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

Patch Set 7: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46040 )

Change subject: drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi
......................................................................

drivers/wifi/generic: Do not generate SAR tables for non-Intel WiFi

CBFS SAR and SAR tables in ACPI are currently supported only by Intel
WiFi devices. This change adds a check in `emit_sar_acpi_structures()`
to ensure that the PCI vendor for the device is Intel before
generating the SAR tables.

BUG=b:169802515
BRANCH=zork

Change-Id: Ibff437893a61ac9557cff243a70230f101089834
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46040
Reviewed-by: Michael Niewöhner 
Reviewed-by: Duncan Laurie 
Reviewed-by: Rob Barnes 
Tested-by: build bot (Jenkins) 
---
M src/drivers/wifi/generic/generic.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved
  Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c
index 1b15211..e8184d8 100644
--- a/src/drivers/wifi/generic/generic.c
+++ b/src/drivers/wifi/generic/generic.c
@@ -44,12 +44,16 @@
    return -1;
 }

-static void emit_sar_acpi_structures(void)
+static void emit_sar_acpi_structures(const struct device *dev)
 {
    int i, j, package_size;
    struct wifi_sar_limits sar_limits;
    struct wifi_sar_delta_table *wgds;

+	/* CBFS SAR and SAR ACPI tables are currently used only by Intel WiFi devices. */
+	if (dev->vendor != PCI_VENDOR_ID_INTEL)
+		return;
+
    /* Retrieve the sar limits data */
    if (get_wifi_sar_limits(&sar_limits) < 0) {
    	printk(BIOS_ERR, "Error: failed from getting SAR limits!\n");
@@ -217,7 +221,7 @@

/* Fill Wifi sar related ACPI structures */
    if (CONFIG(USE_SAR))
-		emit_sar_acpi_structures();
+		emit_sar_acpi_structures(dev);

acpigen_pop_len(); /* Device */
    acpigen_pop_len(); /* Scope */