Change in coreboot[master]: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL
TEST=Able to dump FD contain using below command
ifdtool -p tgl -d coreboot.rom
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I0c9106051f4daf592d2467ebf79f9ddb037011dc --- M util/ifdtool/ifdtool.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/44809/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 7f4753d..6777316 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1450,10 +1450,14 @@ " -M | --altmedisable <0|1> Set the MeDisable and AltMeDisable (or HAP for skylake or newer platform)\n" " bits to disable ME\n" " -p | --platform Add platform-specific quirks\n" + " adl - Alder Lake\n" " aplk - Apollo Lake\n" " cnl - Cannon Lake\n" " glk - Gemini Lake\n" + " icl - Ice Lake\n" + " jsl - Jasper Lake\n" " sklkbl - Skylake/Kaby Lake\n" + " tgl - Tiger Lake\n" " -S | --setpchstrap Write a PCH strap\n" " -V | --newvalue The new value to write into PCH strap specified by -S\n" " -v | --version: print the version\n"
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44809
to look at the new patch set (#2).
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL
BUG=b:153888802 TEST=Able to dump FD contain using below command
ifdtool -p tgl -d coreboot.rom
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I0c9106051f4daf592d2467ebf79f9ddb037011dc --- M util/ifdtool/ifdtool.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/44809/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c@1453 PS2, Line 1453: " adl - Alder Lake\n" : " aplk - Apollo Lake\n" : " cnl - Cannon Lake\n" : " glk - Gemini Lake\n" : " icl - Ice Lake\n" : " jsl - Jasper Lake\n" : " sklkbl - Skylake/Kaby Lake\n" : " tgl - Tiger Lake\n" : " -S | --setpchstrap Write a PCH strap\n" minor nit: would be nice to line these up as well: "adl - Alder Lake\n" "aplk - Apollo Lake\n" "cnl - Cannon Lake\n" "glk - Gemini Lake\n" "icl - Ice Lake\n" "jsl - Jasper Lake\n" "sklkbl - Skylake/Kaby Lake\n"
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Stefan Reinauer, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44809
to look at the new patch set (#3).
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL
BUG=b:153888802 TEST=Able to dump FD contain using below command
ifdtool -p tgl -d coreboot.rom
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I0c9106051f4daf592d2467ebf79f9ddb037011dc --- M util/ifdtool/ifdtool.c 1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/44809/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c@1453 PS2, Line 1453: " adl - Alder Lake\n" : " aplk - Apollo Lake\n" : " cnl - Cannon Lake\n" : " glk - Gemini Lake\n" : " icl - Ice Lake\n" : " jsl - Jasper Lake\n" : " sklkbl - Skylake/Kaby Lake\n" : " tgl - Tiger Lake\n" : " -S | --setpchstrap Write a PCH strap\n"
minor nit: would be nice to line these up as well: […]
Ack
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL
BUG=b:153888802 TEST=Able to dump FD contain using below command
ifdtool -p tgl -d coreboot.rom
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I0c9106051f4daf592d2467ebf79f9ddb037011dc Reviewed-on: https://review.coreboot.org/c/coreboot/+/44809 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M util/ifdtool/ifdtool.c 1 file changed, 8 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 7f4753d..2835ba8 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1450,10 +1450,14 @@ " -M | --altmedisable <0|1> Set the MeDisable and AltMeDisable (or HAP for skylake or newer platform)\n" " bits to disable ME\n" " -p | --platform Add platform-specific quirks\n" - " aplk - Apollo Lake\n" - " cnl - Cannon Lake\n" - " glk - Gemini Lake\n" - " sklkbl - Skylake/Kaby Lake\n" + " adl - Alder Lake\n" + " aplk - Apollo Lake\n" + " cnl - Cannon Lake\n" + " glk - Gemini Lake\n" + " icl - Ice Lake\n" + " jsl - Jasper Lake\n" + " sklkbl - Sky Lake/Kaby Lake\n" + " tgl - Tiger Lake\n" " -S | --setpchstrap Write a PCH strap\n" " -V | --newvalue The new value to write into PCH strap specified by -S\n" " -v | --version: print the version\n"
-
Patrick Georgi (Code Review) -
Subrata Banik (Code Review)
-
Tim Wawrzynczak (Code Review)