Attention is currently required from: Matt DeVillier, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49464 )
Change subject: mb/purism/librem_cnl: Update HDA verbs for Librem Mini
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/49464/comment/714b33a5_f3baec16
PS1, Line 27: AZALIA_PIN_CFG(2, 0x05, 0x18560010),
: AZALIA_PIN_CFG(2, 0x06, 0x18560010),
: AZALIA_PIN_CFG(2, 0x07, 0x18560010),
all I changed was the group number (as noted in commit msg), to be consistent with the value used in […]
Ah, alrighty. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49464
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9fca5d9795d56bd38c8ea47f8de985c14ac8fab
Gerrit-Change-Number: 49464
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 16 Jan 2021 17:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment