Change in ...coreboot[master]: {drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )

Change subject: {drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................

Patch Set 27:

(5 comments)

https://review.coreboot.org/#/c/29662/27//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29662/27//COMMIT_MSG@9 
PS27, Line 9: No C_ENVIRONMENT_BOOTBLOCK support for Braswell is available.
Nit: somewhat trivial from the commit title.

https://review.coreboot.org/#/c/29662/27//COMMIT_MSG@13 
PS27, Line 13: romstage_c_entry
you have hooks to do this in the bootblock.

https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c 
File src/drivers/intel/fsp1_1/car.c:

https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c@105 
PS27, Line 105: car_soc_pre_console_init();
              : 	car_mainboard_pre_console_init();
You generally want the console set up in the bootblock, not in the romstage with C_ENVIRONMENT_BOOTBLOCK. See bootblock_soc_early_init() and bootblock_mainboard_early_init()

https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c@110 
PS27, Line 110: car_soc_post_console_init();
              : 	car_mainboard_post_console_init();
Similarly you have bootblock_soc_init() and bootblock_mainboard_init().

https://review.coreboot.org/#/c/29662/27/src/soc/intel/braswell/bootblock/bo... 
File src/soc/intel/braswell/bootblock/bootblock.c:

https://review.coreboot.org/#/c/29662/27/src/soc/intel/braswell/bootblock/bo... 
PS27, Line 50: 
Where is this done now?