Martin Roth has posted comments on this change. ( https://review.coreboot.org/22678 )
Change subject: soc/amd/stoneyridge: Add USB OC support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c File src/soc/amd/stoneyridge/usb.c:
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@30 PS1, Line 30: nit: Extra newlines here and above
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@32 PS1, Line 32: == Is there a reason for this spacing?
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@36 PS1, Line 36: (uint32_t) I don't think this cast is needed.