Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58692 )
Change subject: mb/google/brya/var/brask: Correct the GPIO config of buzzer ......................................................................
mb/google/brya/var/brask: Correct the GPIO config of buzzer
GPP_B14 is used by buzzer and should be set to NF1 'SPKR'.
BUG=b:198998974 TEST=emerge-brask coreboot depthcharge and verify if the buzzer beeps.
Signed-off-by: Alan Huang alan-huang@quanta.corp-partner.google.com Change-Id: I84978af152a7117c1f3398a9b7adde161db058dd Reviewed-on: https://review.coreboot.org/c/coreboot/+/58692 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/brya/variants/baseboard/brask/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c index ae44c0d..d9cbdb0 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/brask/gpio.c @@ -79,8 +79,8 @@ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* B13 : PLTRST# ==> PLT_RST_L */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), - /* B14 : SPKR ==> GPP_B14_STRAP */ - PAD_NC(GPP_B14, NONE), + /* B14 : SPKR ==> PWM_PP3300_BUZZER */ + PAD_CFG_NF(GPP_B14, NONE, DEEP, NF1), /* B15 : TIME_SYNC0 ==> TP159 */ PAD_NC(GPP_B15, NONE), /* B16 : I2C5_SDA ==> NC */