Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52835 )
Change subject: soc/intel/cannonlake: Use set_dev_state_by_devicetree()
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/cannonlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118180):
https://review.coreboot.org/c/coreboot/+/52835/comment/713f319a_36ea9eef
PS1, Line 324: if (!xdci_can_enable()) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5fed7d37676458354b24b8426cf8e77f32292ab
Gerrit-Change-Number: 52835
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 02 May 2021 23:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment