Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig
BUG=b:140268415
Change-Id: Ic1463181b4a9dca136d00cb2f7e3cce4f7e57bd6 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35301/1
diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index 541ec47..d0d582f 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -156,6 +156,11 @@ hex default 0x10000 depends on FSP_USES_CB_STACK + help + The amount of anticipated heap usage in CAR by FSP to setup HOB. + This configuration is applicable with FSP specification using single + stack implementation. + Sync this value with Platform FSP integration guide recommendation.
config VERIFY_HOBS bool "Verify the FSP hand-off-blocks"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc... PS1, Line 157: default 0x10000 Should this default value be removed?
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc... PS1, Line 161: single : stack implementation shared stack with coreboot/bootloader?
Hello Patrick Rudolph, Aamir Bohra, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35301
to look at the new patch set (#2).
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig
BUG=b:140268415
Change-Id: Ic1463181b4a9dca136d00cb2f7e3cce4f7e57bd6 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35301/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc... PS1, Line 157: default 0x10000
Should this default value be removed?
Done
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc... PS1, Line 161: single : stack implementation
shared stack with coreboot/bootloader?
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 2:
This change should go in along with the next CL else boards would be broken.
Hello Patrick Rudolph, Aamir Bohra, V Sowmya, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35301
to look at the new patch set (#3).
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig
For CML & ICL, FSP requires at least heap = 0x10000 and stack = 0x20000. Refer to FSP integration guide to know the exact FSP requirement.
BUG=b:140268415 TEST=Build and boot CML-Hatch and ICL.
Change-Id: Ic1463181b4a9dca136d00cb2f7e3cce4f7e57bd6 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/drivers/intel/fsp2_0/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/icelake/Kconfig 3 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35301/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 2:
Patch Set 2:
This change should go in along with the next CL else boards would be broken.
agree. clubbed into 1 now
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig ......................................................................
intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig
For CML & ICL, FSP requires at least heap = 0x10000 and stack = 0x20000. Refer to FSP integration guide to know the exact FSP requirement.
BUG=b:140268415 TEST=Build and boot CML-Hatch and ICL.
Change-Id: Ic1463181b4a9dca136d00cb2f7e3cce4f7e57bd6 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35301 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/fsp2_0/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/icelake/Kconfig 3 files changed, 23 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index 541ec47..1e84dab 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -154,8 +154,12 @@
config FSP_TEMP_RAM_SIZE hex - default 0x10000 depends on FSP_USES_CB_STACK + help + The amount of anticipated heap usage in CAR by FSP to setup HOB. + This configuration is applicable for FSP specification using shared + stack with coreboot/bootloader. + Sync this value with Platform FSP integration guide recommendation.
config VERIFY_HOBS bool "Verify the FSP hand-off-blocks" diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index d949fff..fc3f2ac 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -125,6 +125,15 @@ The amount of anticipated stack usage in CAR by bootblock and other stages.
+config FSP_TEMP_RAM_SIZE + hex + depends on FSP_USES_CB_STACK + default 0x10000 + help + The amount of anticipated heap usage in CAR by FSP. + Refer to Platform FSP integration guide document to know + the exact FSP requirement for Heap setup. + config IFD_CHIPSET string default "cnl" diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 1bd478c..05fe423 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -76,6 +76,15 @@ The amount of anticipated stack usage in CAR by bootblock and other stages.
+config FSP_TEMP_RAM_SIZE + hex + depends on FSP_USES_CB_STACK + default 0x10000 + help + The amount of anticipated heap usage in CAR by FSP. + Refer to Platform FSP integration guide document to know + the exact FSP requirement for Heap setup. + config IFD_CHIPSET string default "icl"
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)