[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PLL and Clock init support

[Jarried Lin (Code Review)]

Attention is currently required from: Guangjie Song, Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84495?usp=email )

Change subject: soc/mediatek/mt8196: Add PLL and Clock init support
......................................................................

Patch Set 26:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84495/comment/e86f6476_24956ab8?usp... :
PS18, Line 10: raising
> Move this word to the previous line.

Done

File src/soc/mediatek/mt8196/include/soc/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/84495/comment/6ba37a4a_91d47eb1?usp... :
PS19, Line 46: 85K
> With mtcmos (CB:84497), the booblock size is about 78K

Done

File src/soc/mediatek/mt8196/pll.c:

https://review.coreboot.org/c/coreboot/+/84495/comment/3c8aff8c_d0188d1b?usp... :
PS13, Line 1196: 30
> What do you mean by "not used"? The `cg_idx` field for all `mmvote_cg_mtcmos_table` members is *used […]

@[e-mail] 
Please help to respond to this comment. Thank you

File src/soc/mediatek/mt8196/pll.c:

https://review.coreboot.org/c/coreboot/+/84495/comment/d44bb7b8_b8d330ec?usp... :
PS18, Line 1484: 	if (fm_data->id == VLP_CKSYS_CTRL)
> Add {}

Done

https://review.coreboot.org/c/coreboot/+/84495/comment/f57341e2_5d965a48?usp... :
PS18, Line 1794: 0x100
> `BIT(8)`

Done

File src/soc/mediatek/mt8196/pll.c:

https://review.coreboot.org/c/coreboot/+/84495/comment/7c76f44d_0eb40cb8?usp... :
PS19, Line 773:
> remove one blank line

Done

https://review.coreboot.org/c/coreboot/+/84495/comment/827b204e_f4c6c524?usp... :
PS19, Line 1464: fm_data->id == MFGPLL_SC1_CTRL)
> move to the next line and align with `fm_data->id == MFGPLL_CTRL`

Done

https://review.coreboot.org/c/coreboot/+/84495/comment/a6be1a42_2dcb4cb3?usp... :
PS19, Line 1512: fm_data->id == MFGPLL_SC1_CTRL)
> ditto

Done

https://review.coreboot.org/c/coreboot/+/84495/comment/ddabc10b_1ab793f6?usp... :
PS19, Line 1528: mt_cpu_get_freq
> mt_get_cpu_freq

Done