Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45490 )
Change subject: [WIP] mb/system76/lemp9: use the newly added CNL vGPIOs ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 308: PAD_CFG_GPIO_BIDIRECT(CNV_GNEN, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ this looks strange...
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 311: PAD_CFG_GPI_TRIG_OWN(CNV_BT_HOST_WAKE_B, NONE, DEEP, OFF, ACPI), /* GPIO */ not sure
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 312: PAD_CFG_GPO(CNV_BT_IF_SELECT, 1, DEEP), /* GPIO */ check this
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 313: PAD_CFG_GPIO_BIDIRECT(vCNV_BT_UART_TXD, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_BT_UART_RXD, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_BT_UART_CTS_B, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_BT_UART_RTS_B, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : this looks strange...
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 321: n/a this is WIP in inteltool
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 329: mapped yeah, that's WIP in inteltool...
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 325: PAD_CFG_GPIO_BIDIRECT(vUART0_TXD, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vUART0_RXD, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vUART0_CTS_B, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vUART0_RTS_B, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : this looks strange...
https://review.coreboot.org/c/coreboot/+/45490/2/src/mainboard/system76/lemp... PS2, Line 337: PAD_CFG_GPIO_BIDIRECT(vCNV_BT_I2S_BCLK, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_BT_I2S_WS_SYNC, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_BT_I2S_SDO, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_BT_I2S_SDI, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vSSP2_SCLK, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vSSP2_SFRM, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vSSP2_TXD, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vSSP2_RXD, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vCNV_GNSS_HOST_WAKE_B, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : PAD_CFG_GPIO_BIDIRECT(vSD3_CD_B, 0, NONE, DEEP, OFF, ACPI), /* GPIO */ : this looks strange...