Change in coreboot[master]: mb/facebook/monolith: Remove the power button from ASL

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Wim Vervoorn (Code Review)

2 Jan 2020 2 Jan '20

1:47 p.m.

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Remove the power button from ASL ......................................................................

mb/facebook/monolith: Remove the power button from ASL

The mainboard ASL code contained a power button definition. This is not required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A TEST=tested using fwts on a facebook monolith.

Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/acpi/mainboard.asl 1 file changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38133/1

diff --git a/src/mainboard/facebook/monolith/acpi/mainboard.asl b/src/mainboard/facebook/monolith/acpi/mainboard.asl index 2a3ad59..f40af80 100644 --- a/src/mainboard/facebook/monolith/acpi/mainboard.asl +++ b/src/mainboard/facebook/monolith/acpi/mainboard.asl @@ -15,15 +15,6 @@ * GNU General Public License for more details. */

-Scope (_SB) -{ - Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - Name (_UID, 1) - } -} - /* * Onboard CPLD */

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Frans Hendriks (Code Review)

2 Jan 2 Jan

1:53 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Remove the power button from ASL ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/monolith: Remove the power button from ASL Would suggest 'Remove PWRB' since standard power button is used.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 1 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Comment-Date: Thu, 02 Jan 2020 12:53:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

1:59 p.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Remove the PWRB device as standard power button...

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38133

to look at the new patch set (#2).

Change subject: mb/facebook/monolith: Remove the PWRB device as standard power button is used ......................................................................

mb/facebook/monolith: Remove the PWRB device as standard power button is used

The mainboard ASL code contained a power button definition. This is not required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A TEST=tested using fwts on a facebook monolith.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38133/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Wim Vervoorn (Code Review)

2:11 p.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Remove the PWRB device as standard power button...

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Remove the PWRB device as standard power button is used ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/monolith: Remove the power button from ASL

...

Would suggest 'Remove PWRB' since standard power button is used.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 02 Jan 2020 13:11:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: comment

Frans Hendriks (Code Review)

3 Jan 3 Jan

7:37 a.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Remove the PWRB device as standard power button...

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Remove the PWRB device as standard power button is used ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38133/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38133/2//COMMIT_MSG@7 PS2, Line 7: mb/facebook/monolith: Remove the PWRB device as standard power button is used Use 'Drop PWRB device' as in CB:38134

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Jan 2020 06:37:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

9:07 a.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38133

to look at the new patch set (#3).

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

mb/facebook/monolith: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A TEST=tested using fwts on a facebook monolith.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38133/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 3 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Wim Vervoorn (Code Review)

9:07 a.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38133/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38133/2//COMMIT_MSG@7 PS2, Line 7: mb/facebook/monolith: Remove the PWRB device as standard power button is used

...

Use 'Drop PWRB device' as in CB:38134

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 3 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Jan 2020 08:07:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: comment

Frans Hendriks (Code Review)

9:22 a.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 3 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Jan 2020 08:22:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

16 Jan 16 Jan

12:19 p.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG@13 PS1, Line 13: Found-by: …

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 3 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jan 2020 11:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

1:03 p.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Hello Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38133

to look at the new patch set (#4).

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

mb/facebook/monolith: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A TEST=tested using fwts on a facebook monolith.

Found-by: fwts 19.12.00 Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/acpi/mainboard.asl 1 file changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38133/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Wim Vervoorn (Code Review)

1:04 p.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38133/1//COMMIT_MSG@13 PS1, Line 13:

...

Found-by: …

forgot to update this one as well. Sorry about that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 4 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jan 2020 12:04:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Frans Hendriks (Code Review)

20 Jan 20 Jan

9:09 a.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 5 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 08:09:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11:56 a.m.

New subject: Change in coreboot[master]: mb/facebook/monolith: Drop PWRB device

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38133 )

Change subject: mb/facebook/monolith: Drop PWRB device ......................................................................

mb/facebook/monolith: Drop PWRB device

The mainboard ASL code contained a power button definition. This is not required as the system uses the standard ACPI power button.

Remove the PWRB device from ASL.

BUG=N/A TEST=tested using fwts on a facebook monolith.

Found-by: fwts 19.12.00 Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38133 Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/monolith/acpi/mainboard.asl 1 file changed, 0 insertions(+), 9 deletions(-)

Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved

-Scope (_SB) -{ - Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - Name (_UID, 1) - } -} - /* * Onboard CPLD */

-- To view, visit https://review.coreboot.org/c/coreboot/+/38133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25a842539ee2e8febc8a1ae88843a71ccb4ee68e Gerrit-Change-Number: 38133 Gerrit-PatchSet: 6 Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1925

days inactive

1943

days old

coreboot-gerrit@coreboot.org

12 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Wim Vervoorn (Code Review)