Change in coreboot[master]: mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support
Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42772
to review the following change.
Change subject: mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support ......................................................................
mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support
Add Samsung K4F8E3S4HD-MGCL DRAM support. DRAMID: 0x8
BUG=b:145094527 BRANCH=master TEST=emerge-snappy coreboot chromeos-bootimage
Change-Id: Ic450c4abebfeaed050a7b8fcae74b87a148dd5cd Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/reef/variants/baseboard/memory.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42772/1
diff --git a/src/mainboard/google/reef/variants/baseboard/memory.c b/src/mainboard/google/reef/variants/baseboard/memory.c index 260b6fa..aac160b 100644 --- a/src/mainboard/google/reef/variants/baseboard/memory.c +++ b/src/mainboard/google/reef/variants/baseboard/memory.c @@ -131,6 +131,13 @@ .ch1_rank_density = LP4_16Gb_DENSITY, .part_num = "K4F6E3S4HM-MGCJ", }, + /* K4F8E3S4HD-MGCL - both logical channels */ + [8] = { + .speed = LP4_SPEED_2400, + .ch0_rank_density = LP4_8Gb_DENSITY, + .ch1_rank_density = LP4_8Gb_DENSITY, + .part_num = "K4F8E3S4HD-MGCL", + }, };
static const struct lpddr4_cfg lp4cfg = {
Kevin Chiu has removed Kevin Chiu from this change. ( https://review.coreboot.org/c/coreboot/+/42772 )
Change subject: mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support ......................................................................
Removed reviewer Kevin Chiu.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42772 )
Change subject: mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42772 )
Change subject: mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support ......................................................................
mb/google/reef/variants/: add Samsung K4F8E3S4HD-MGCL support
Add Samsung K4F8E3S4HD-MGCL DRAM support. DRAMID: 0x8
BUG=b:145094527 BRANCH=master TEST=emerge-snappy coreboot chromeos-bootimage
Change-Id: Ic450c4abebfeaed050a7b8fcae74b87a148dd5cd Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42772 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/reef/variants/baseboard/memory.c 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/reef/variants/baseboard/memory.c b/src/mainboard/google/reef/variants/baseboard/memory.c index 260b6fa..aac160b 100644 --- a/src/mainboard/google/reef/variants/baseboard/memory.c +++ b/src/mainboard/google/reef/variants/baseboard/memory.c @@ -131,6 +131,13 @@ .ch1_rank_density = LP4_16Gb_DENSITY, .part_num = "K4F6E3S4HM-MGCJ", }, + /* K4F8E3S4HD-MGCL - both logical channels */ + [8] = { + .speed = LP4_SPEED_2400, + .ch0_rank_density = LP4_8Gb_DENSITY, + .ch1_rank_density = LP4_8Gb_DENSITY, + .part_num = "K4F8E3S4HD-MGCL", + }, };
static const struct lpddr4_cfg lp4cfg = {
-
Furquan Shaikh (Code Review) -
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)