Attention is currently required from: Michał Żygowski, Jeremy Soller, Angel Pons, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Piotr Król. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51340 )
Change subject: mainboard: Drop invalid `VGA_BIOS_FILE` defaults ......................................................................
Patch Set 2: Code-Review-2
(1 comment)
Patchset:
PS2: Not everything contained in these configurations is all about what's in coreboot tree. I have no objection to removing things that are commented out, but others may be currently required to build in a different repository. You can argue that that shouldn't be the case, but this patch as is will break a lot of google boards, and maybe others. Let's not arbitrarily break things without a REALLY GOOD reason.
Since the default is that the vga_bios is set to disabled then these aren't even used in the typical build, so leaving them doesn't hurt anything.
Just setting -2 so it doesn't get merged without further discussion.
If you believe that everything in the coreboot tree should ONLY be about the coreboot tree, let's take that question to the mailing list and the leadership meeting. It would be a significant change of policy.
-
Martin Roth (Code Review)