Jorge Fernandez has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37618 )
Change subject: amd/bettong: Enable SATA controller ......................................................................
amd/bettong: Enable SATA controller
A minor typo fixed and the SATA controller is enabled on FCH reset.
Change-Id: Ib5a66a99379f53b7376dd69e58bb4c1cb082f20b Signed-off-by: Jorge Fernandez jorgefm@cirsa.com --- M src/mainboard/amd/bettong/BiosCallOuts.c 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37618/1
diff --git a/src/mainboard/amd/bettong/BiosCallOuts.c b/src/mainboard/amd/bettong/BiosCallOuts.c index e983690..3d2aa48 100644 --- a/src/mainboard/amd/bettong/BiosCallOuts.c +++ b/src/mainboard/amd/bettong/BiosCallOuts.c @@ -60,7 +60,7 @@ */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control. the recommended way */ imc_reg_init();
FchParams->Imc.ImcEnable = TRUE; @@ -87,6 +87,10 @@ FchParams_reset->FchReset.Xhci0Enable = CONFIG(HUDSON_XHCI_ENABLE); FchParams_reset->FchReset.Xhci1Enable = FALSE; FchParams_reset->EarlyOemGpioTable = oem_bettong_gpio; + + /* SATA configuration */ + FchParams_reset->FchReset.SataEnable = TRUE; + } else if (StdHeader->Func == AMD_INIT_ENV) { FCH_DATA_BLOCK *FchParams_env = (FCH_DATA_BLOCK *)FchData; printk(BIOS_DEBUG, "Fch OEM config in INIT ENV "); @@ -103,7 +107,6 @@ FchParams_env->Usb.Xhci1Enable = FALSE; FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is unremoveable. */
- /* sata configuration */ /* SD configuration */ /* Rev F has an on-board eMMC, which only supports SD 2.0 */ if (board_id() == 'F') {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37618 )
Change subject: amd/bettong: Enable SATA controller ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37618/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37618/1//COMMIT_MSG@9 PS1, Line 9: the SATA controller is enabled on FCH reset So it worked before, or not?
Did the original porters only test with IDE stuff and not S-ATA/AHCI?
https://review.coreboot.org/c/coreboot/+/37618/1/src/mainboard/amd/bettong/B... File src/mainboard/amd/bettong/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/37618/1/src/mainboard/amd/bettong/B... PS1, Line 63: /* Enable IMC fan control. the recommended way */ Such unrelated fixes need to go in a separate commit.
https://review.coreboot.org/c/coreboot/+/37618/1/src/mainboard/amd/bettong/B... PS1, Line 93: Please remove the blank line.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37618
to look at the new patch set (#2).
Change subject: amd/bettong: Enable SATA controller ......................................................................
amd/bettong: Enable SATA controller
Enable SATA controller on FCH reset.
Change-Id: Ib5a66a99379f53b7376dd69e58bb4c1cb082f20b Signed-off-by: Jorge Fernandez jorgefm@cirsa.com --- M src/mainboard/amd/bettong/BiosCallOuts.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37618/2
Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37618 )
Change subject: amd/bettong: Enable SATA controller ......................................................................
Patch Set 2:
Patch Set 1:
(3 comments)
I don't know what the original porters tested, but SATA was not working. Maybe they used USB3 to boot.
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37618?usp=email )
Change subject: amd/bettong: Enable SATA controller ......................................................................
Abandoned
-
Jorge Fernandez (Code Review) -
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)