Attention is currently required from: Vinod Polimera, Douglas Anderson, Xuxin Xiong.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52959 )
Change subject: drivers/sn65dsi86: Switch EDID reading to use "indirect mode"
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/52959/comment/23ac7337_bf656adc
PS2, Line 201: AUX_CMD_SEND
From looking at the kernel code (and the samples in the ti manual IIRC), I believe you can't set thi […]
Sorry, I must have been tired or something... you're totally right of course. I'm not sure if setting the command before the send bit really makes a difference but I can do it just in case, too.
We were also not waiting for acknowledgement when writing with the old code... probably a good idea to add that, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65f80193380d3c3841f9f5c26897ed672f45e15a
Gerrit-Change-Number: 52959
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Douglas Anderson
dianders@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 07 May 2021 00:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Douglas Anderson
dianders@chromium.org
Gerrit-MessageType: comment