Change in coreboot[master]: soc/amd/{cezanne,common}/acpi: Add _OSC method - coreboot-gerrit

21 Apr 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52528 )
Change subject: soc/amd/{cezanne,common}/acpi: Add _OSC method
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/acpi/osc.asl:
https://review.coreboot.org/c/coreboot/+/52528/comment/10eeed48_09c6f9f0 
PS3, Line 16: /* Don't mask any capability bits off. */
...
The guide is wrong... It places the OSC object in the wrong scope, so it never gets called. […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52528
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44e554b9db6f70fdd1559105cdaee53aeb2bfbf5
Gerrit-Change-Number: 52528
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 21 Apr 2021 22:26:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment