Aseda Aboagye has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source. ......................................................................
google/nocturne: Add MKBP events as a wake source.
We would like to wake nocturne up in suspend from an MKBP event. On Nocturne, MKBP events are notified to the host via a GPIO from the EC, EC_INT_L. However, the AP cannot wake from suspend from this GPIO. Therefore, we'll use the host event interface to wake the system instead.
This commit simply enables MKBP events to wake the system in suspend.
BUG=chromium:786721 BRANCH=firmware-nocturne-10984.B TEST=Build and flash nocturne, generate MKBP events on the EC and verify that the system wakes up in suspend.
Change-Id: I6aff4d38051c939257533229fd0085e42c01d02f Signed-off-by: Aseda Aboagye aaboagye@google.com --- M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/34388/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h index 46e848b..dfb0f74 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h @@ -48,6 +48,7 @@ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source. ......................................................................
Patch Set 1: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source. ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG@7 PS1, Line 7: google/nocturne: Add MKBP events as a wake source. Please remove the dot/period at the end of the commit message.
Hello Nick Vaccaro, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34388
to look at the new patch set (#2).
Change subject: google/nocturne: Add MKBP events as a wake source ......................................................................
google/nocturne: Add MKBP events as a wake source
We would like to wake nocturne up in suspend from an MKBP event. On Nocturne, MKBP events are notified to the host via a GPIO from the EC, EC_INT_L. However, the AP cannot wake from suspend from this GPIO. Therefore, we'll use the host event interface to wake the system instead.
This commit simply enables MKBP events to wake the system in suspend.
BUG=chromium:786721 BRANCH=firmware-nocturne-10984.B TEST=Build and flash nocturne, generate MKBP events on the EC and verify that the system wakes up in suspend.
Change-Id: I6aff4d38051c939257533229fd0085e42c01d02f Signed-off-by: Aseda Aboagye aaboagye@google.com --- M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/34388/2
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG@7 PS1, Line 7: google/nocturne: Add MKBP events as a wake source.
Please remove the dot/period at the end of the commit message.
Done. I'm curious, what's the rationale for that?
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34388/1//COMMIT_MSG@7 PS1, Line 7: google/nocturne: Add MKBP events as a wake source.
Done. […]
I think this is a pretty common guide for commit messages. I've read it in a few different recommendations for formatting commits.
"Trailing punctuation is unnecessary in subject lines. Besides, space is precious when you’re trying to keep them [short]."
https://chris.beams.io/posts/git-commit/
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34388 )
Change subject: google/nocturne: Add MKBP events as a wake source ......................................................................
google/nocturne: Add MKBP events as a wake source
We would like to wake nocturne up in suspend from an MKBP event. On Nocturne, MKBP events are notified to the host via a GPIO from the EC, EC_INT_L. However, the AP cannot wake from suspend from this GPIO. Therefore, we'll use the host event interface to wake the system instead.
This commit simply enables MKBP events to wake the system in suspend.
BUG=chromium:786721 BRANCH=firmware-nocturne-10984.B TEST=Build and flash nocturne, generate MKBP events on the EC and verify that the system wakes up in suspend.
Change-Id: I6aff4d38051c939257533229fd0085e42c01d02f Signed-off-by: Aseda Aboagye aaboagye@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34388 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h index 46e848b..dfb0f74 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h @@ -48,6 +48,7 @@ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
-
Aseda Aboagye (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)
-
Nick Vaccaro (Code Review)
-
Paul Menzel (Code Review)