[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 12:
(3 comments)
File src/ec/clevo/it5570e/i2ec.h:
https://review.coreboot.org/c/coreboot/+/68791/comment/20890a65_8f02b580 PS4, Line 10: #define D2ADR 0x2e
Ah, thanks for the explanation. […]
that's what the comment on line 13 tried to do ;) I'll make it clearer
File src/ec/clevo/it5570e/i2ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/e0d39857_bf74a960 PS4, Line 11: 0x2e
OK, so it's not the same thing. It would be best to use the PNP infrastructure, see <device/pnp_ops.h> .
Ah yes, thanks for the hint. I thought PNP ops were not present in bootblock but they are
File src/ec/clevo/it5570e/i2ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/88bf5791_594962f6 PS12, Line 17: I2EC_ADDR_H
"Writing" (won't work because `outb(value, port)` arguments are backwards) 2 times to the same regis […]
good catch. I'm completely confused now... I had tested the backlight effect switch and it worked... but with this code it never could work... need to check my reflog what went wrong and where.... o.O
-
Michael Niewöhner (Code Review)